Skip to content

Conversation

@janbarasek
Copy link
Contributor

@janbarasek janbarasek commented Jan 5, 2021

  • new feature
  • BC break? no

Very often I need to write to a directory where I cannot guarantee the correctly set permissions in advance.

This feature can try to fix the permissions according to the settings, or throw an exception.

Directory permissions are set recursively.

@JanTvrdik
Copy link
Contributor

  1. fix permission is bad name; it should be called changePermissions (with removal of default values for $dirMode and $fileMode) or makeWritable (and keep the default values)
  2. i'm not sure if you need the $recursive parameter as everything in FileSytem is always recursive

@janbarasek janbarasek changed the title FileSystem: Add method fixPermissions(). FileSystem: Add method makeWritable(). Jan 5, 2021
@janbarasek
Copy link
Contributor Author

@JanTvrdik Fixed, thanks.

@dg dg force-pushed the master branch 5 times, most recently from 740520b to 2bc2f58 Compare January 11, 2021 03:06
@dg dg force-pushed the master branch 11 times, most recently from eb3a987 to adead06 Compare March 4, 2021 20:13
@dg dg force-pushed the master branch 3 times, most recently from c5fe864 to f06376c Compare April 22, 2021 16:23
@dg dg changed the title FileSystem: Add method makeWritable(). FileSystem: Add method makeWritable() Aug 16, 2021
@dg dg merged commit 1d3a574 into nette:master Aug 16, 2021
dg pushed a commit that referenced this pull request Aug 16, 2021
dg pushed a commit that referenced this pull request Aug 16, 2021
dg pushed a commit that referenced this pull request Aug 16, 2021
dg pushed a commit that referenced this pull request Aug 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants