test: Cleanup test setup #1441
Merged
test: Cleanup test setup #1441
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Setup some global location within the setup, also use vmForks so CSS files are correctly mocked during tests. This allows to not inline nextcloud files so we can properly mock it if needed (e.g. for public share tests). Signed-off-by: Ferdinand Thiessen <[email protected]>
susnux
requested review from
Pytal,
juliusknorr and
skjnldsv
and removed request for
juliusknorr
Bundle ReportBundle size has no change ✅ |
skjnldsv
approved these changes
Oct 17, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setup some global location within the setup, also use vmForks so CSS files are correctly mocked during tests. This allows to not inline nextcloud files so we can properly mock it if needed (e.g. for public share tests).