fix: Fix adding children to directory (file tree) for batch uploading #1463
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`addChild` is asynchronous and needs to be awaited, as `readEntries` is also async. This means it can not be done in the constructor but we need to handle this separately. So instead just add a `addChildren` helper method and await this function where needed. Signed-off-by: Ferdinand Thiessen <[email protected]>
Bundle ReportChanges will increase total bundle size by 850 bytes (0.11%) ⬆️. This is within the configured threshold ✅ Detailed changes
|
8 tasks
skjnldsv
approved these changes
Nov 5, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addChildis asynchronous and needs to be awaited, asreadEntriesis also async. This means it can not be done in the constructor but we need to handle this separately.So instead just add a
addChildrenhelper method and await this function where needed.