-
Notifications
You must be signed in to change notification settings - Fork 2
feat: high level wrapper around Docker API #39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
16aab96 to
28ceb51
Compare
kyteinsky
reviewed
May 28, 2025
Contributor
kyteinsky
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
works quite flawlessly, tested even with custom ssl certs. 🚀
Signed-off-by: Oleksander Piskun <[email protected]>
28ceb51 to
8d44b25
Compare
Signed-off-by: Oleksander Piskun <[email protected]>
Signed-off-by: Oleksander Piskun <[email protected]>
andrey18106
approved these changes
May 28, 2025
Signed-off-by: Oleksander Piskun <[email protected]>
Signed-off-by: Oleksander Piskun <[email protected]>
kyteinsky
approved these changes
May 29, 2025
Contributor
kyteinsky
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partitially related to the nextcloud/app_api#531
In this pull request we add a wrapper around Docker Commands for AppAPI for Nextcloud 32.
All the wrapper logic is written in Python, all the main commands for which complex regular expressions for access control were written are covered in this PR.
This is what remains to be done for the future (most likely it will be for Nextcloud 33 or 34 when we drop DockerDockerProxy support):