fix: disable loading when there are no more activities to load

[hamza221]

Fix #1909
I couldn't reproduce in a deterministic manner useInfiniteScroll doesn't always trigger for pages with 1,2 activities disabling it makes reproduction easier.

Repro:

1. Have a tab with one activity
2. If the api request doesn't get triggered a second time with a 304response loading Icons doesn't disappear

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 30.85%. Comparing base (1d69d66) to head (9ec95b2).
Report is 6 commits behind head on master.

Files with missing lines	Patch %	Lines
src/views/ActivityAppFeed.vue	0.00%	3 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1931      +/-   ##
==========================================
- Coverage   30.89%   30.85%   -0.04%     
==========================================
  Files          43       43              
  Lines        1615     1617       +2     
  Branches      110      110              
==========================================
  Hits          499      499              
- Misses       1090     1092       +2     
  Partials       26       26              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[hamza221]

/backport to stable31

[hamza221]

/backport to stable30

[hamza221]

/backport to stable29

[cypress]

Activity    Run #2342

Run Properties:   Passed #2342  •  42d51a8cf4: fix: disable loading when there are no more activities to load

Project	Activity
Branch Review	fix/endless-spinner
Run status	Passed #2342
Run duration	02m 42s
Commit	42d51a8cf4: fix: disable loading when there are no more activities to load
Committer	Hamza
View all properties for this run ↗︎

---

Test results
Failures	0
Flaky	3
Pending	0
Skipped	0
Passing	10
View all changes introduced in this branch ↗︎

[susnux]

Possible improvement in the future: Check again after a timeout if there is something new.

[nickvergessen]

This completely breaks the activity stream and needs reverting!

Basically if you upload more than 50 files, it will be the end of your activity stream. In fact 3 uploads will be enough already. You ask the backend for 50 entries, but only get 48, as 3 of them are combined into 1 entry

I see it's also broken before with the loading spinner you tried to fix, but that is another problem. Checking the result size is not the solution. Whether or not you reached the end of the activity stream is indicated by the HTTP status code 304:
https://github.com/nextcloud/activity/blob/master/docs/endpoint-v2.md#http-status