fix(sendDigests): catch the case that a specified user is not existing and log instead #2064
Conversation
Activity
|
||||||||||||||||||||||||||||
| Project |
Activity
|
| Branch Review |
enh/noid/catch-user-null
|
| Run status |
|
| Run duration | 02m 08s |
| Commit |
|
| Committer | Simon L. |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
10
|
| View all changes introduced in this branch ↗︎ | |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2064 +/- ##
=======================================
Coverage 31.14% 31.14%
=======================================
Files 43 43
Lines 1583 1583
Branches 110 110
=======================================
Hits 493 493
Misses 1064 1064
Partials 26 26 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
szaimen
force-pushed
the
enh/noid/catch-user-null
branch
2 times, most recently
from
597c5e2 to
5087d40
Compare
…g and log instead Signed-off-by: Simon L. <[email protected]> Co-Authored-By: Anna <[email protected]>
szaimen
force-pushed
the
enh/noid/catch-user-null
branch
from
f51b7b9 to
ed7296b
Compare
|
@miaulalala can I merge? |
did you test? then yes |
I dont have an instance where this problem was hapoennjg unfortunately. This was for a customer that didnt get back to me... |
Hm, I don't see a reason why this shouldn't work, although I'm wondering about the circumstances of it happening. Can you try to reproduce by setting up an account, creating some activities with it, then deleting the user and triggering |
No description provided.