feat: use full date and time in activity emails #2078
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Activity
|
||||||||||||||||||||||||||||
| Project |
Activity
|
| Branch Review |
feat/2076/improve-emails
|
| Run status |
|
| Run duration | 02m 22s |
| Commit |
|
| Committer | Anna |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
10
|
| View all changes introduced in this branch ↗︎ | |
miaulalala
force-pushed
the
feat/2076/improve-emails
branch
from
aae6fb7 to
08cd416
Compare
miaulalala
force-pushed
the
feat/2076/improve-emails
branch
from
08cd416 to
1c39376
Compare
miaulalala
force-pushed
the
feat/2076/improve-emails
branch
from
1c39376 to
d2541c0
Compare
Signed-off-by: Anna Larch <[email protected]>
miaulalala
force-pushed
the
feat/2076/improve-emails
branch
from
d2541c0 to
0a771b7
Compare
nickvergessen
approved these changes
Aug 24, 2025
Member
nickvergessen
left a comment
nickvergessen
left a comment
There was a problem hiding this comment.
But otherwise fine by me
Comment on lines
+154
to
+166
|
|
||
| $result = $query->executeQuery(); | ||
|
|
||
| $affectedUsers = []; | ||
| while ($row = $result->fetch()) { | ||
| $affectedUsers[] = $row['amq_affecteduser']; | ||
| } | ||
| $result->closeCursor(); | ||
|
|
||
| return $affectedUsers; | ||
| } | ||
|
|
||
| if ($forceSending) { |
Member
There was a problem hiding this comment.
I prefer simplicity over "early return" which duplicates 12 lines :D
Suggested change
| $result = $query->executeQuery(); | |
| $affectedUsers = []; | |
| while ($row = $result->fetch()) { | |
| $affectedUsers[] = $row['amq_affecteduser']; | |
| } | |
| $result->closeCursor(); | |
| return $affectedUsers; | |
| } | |
| if ($forceSending) { | |
| } elseif ($forceSending) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2076
Also refactors the query for affected users to avoid using a
whereoverwrite for the query.