Improve error logging #510
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Check local socket by assuming it starts with a slash * Improve error logging for ping and deploy Signed-off-by: Robin Windey <[email protected]>
Contributor
|
@kyteinsky or @andrey18106 - second review? note: we will backport this to the NC31/NC30 |
oleksandr-nc
approved these changes
Feb 13, 2025
kyteinsky
approved these changes
Feb 13, 2025
Member
Author
|
/backport to stable31 |
Member
Author
|
/backport to stable30 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #498
Log messages now look like this when doint a ping via UI (if either the docker socket is not writable or the file path doesn't exist)
socket doesn't exist:
socket is not writable:
Also the frontend dialog for the deployment now shows
deployment error for local socket:
deployment error for nextcloud DSP:
Unfortunately I didn't find a way to get rid of the slightly misleading error message that - in case the socket is not usable - curl will always complain about not being able to connect tho
http://localhost/, even though it's not using any http under the hood but trying to access the UNIX socket directly. When using curl in socket mode (CURLOPT_UNIX_SOCKET_PATH), it will still need somehttp-address for the actualGETcall. See also curl/curl#1338