Skip to content

Conversation

@nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Apr 13, 2023

Fix #11

Still changes things in Talk, but that looks "expected" and I couldn't find a rule for that, but at least the { is on the same line again

   4) lib/Participant.php
      ---------- begin diff ----------
--- /home/nickv/Nextcloud/27/server/appsbabies/spreed/lib/Participant.php
+++ /home/nickv/Nextcloud/27/server/appsbabies/spreed/lib/Participant.php
@@ -60,8 +60,8 @@
 	protected ?Session $session;
 
 	public function __construct(Room $room,
-								Attendee $attendee,
-								?Session $session) {
+		Attendee $attendee,
+		?Session $session) {
 		$this->room = $room;
 		$this->attendee = $attendee;
 		$this->session = $session;

      ----------- end diff -----------

Questions

  • Should we keep the old rule and keep supporting 3.2?
  • Or should we remove the old rule and require cs-fixer ^3.16 in composer.json? ☑️

Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

curl_braces_position was added with https://github.com/PHP-CS-Fixer/PHP-CS-Fixer/releases/tag/v3.9.1

Let's use that a minimum requirement

@artonge artonge merged commit 20efa30 into master Apr 13, 2023
@delete-merged-branch delete-merged-branch bot deleted the nickvergessen-patch-1 branch April 13, 2023 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

cs fixer v3.16 moves method braces to a new line

5 participants