fix(rules): Replace deprecated braces rules #12
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #11
Still changes things in Talk, but that looks "expected" and I couldn't find a rule for that, but at least the
{is on the same line again4) lib/Participant.php ---------- begin diff ---------- --- /home/nickv/Nextcloud/27/server/appsbabies/spreed/lib/Participant.php +++ /home/nickv/Nextcloud/27/server/appsbabies/spreed/lib/Participant.php @@ -60,8 +60,8 @@ protected ?Session $session; public function __construct(Room $room, - Attendee $attendee, - ?Session $session) { + Attendee $attendee, + ?Session $session) { $this->room = $room; $this->attendee = $attendee; $this->session = $session; ----------- end diff -----------Questions
Should we keep the old rule and keep supporting 3.2?