Skip to content

fix(logger): Set narrower permissions on temporaryFolderLogDirPath #6533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mgallien merged 1 commit into from
Jul 31, 2025
Merged

fix(logger): Set narrower permissions on temporaryFolderLogDirPath #6533

mgallien merged 1 commit into from
Jul 31, 2025

Conversation

@joshtrichards
Copy link
Member

@joshtrichards joshtrichards commented Mar 11, 2024

No description provided.

@joshtrichards joshtrichards changed the title fix(logger): Set narrower permissions on temporaryFolderLogDirPath [WIP/testing] fix(logger): Set narrower permissions on temporaryFolderLogDirPath Mar 11, 2024
@Rello
Copy link
Collaborator

Rello commented Dec 20, 2024

Hello @joshtrichards
can you have a look at the conflicts? then we can merge it...

@Rello Rello added this to the 3.16.0 milestone Dec 20, 2024
@camilasan camilasan modified the milestones: 3.16.0, 3.17.0 Feb 10, 2025
@mgallien mgallien marked this pull request as draft July 16, 2025 15:35
@camilasan camilasan force-pushed the fix/logger/temp-logdir-permis branch from 298251a to fc054a1 Compare July 28, 2025 08:32
@camilasan camilasan changed the title [WIP/testing] fix(logger): Set narrower permissions on temporaryFolderLogDirPath fix(logger): Set narrower permissions on temporaryFolderLogDirPath Jul 28, 2025
@camilasan camilasan marked this pull request as ready for review July 28, 2025 08:33
@camilasan camilasan requested a review from i2h3 as a code owner July 28, 2025 08:33
@mgallien mgallien force-pushed the fix/logger/temp-logdir-permis branch from fc054a1 to 1130b09 Compare July 31, 2025 12:31
@mgallien mgallien enabled auto-merge July 31, 2025 12:32
@github-actions
Copy link

github-actions bot commented Jul 31, 2025

Artifact containing the AppImage: nextcloud-appimage-pr-6533.zip

SHA256 checksum: 06a0b4173a03b0d9ea2031f91acdb3d9e471739315e3ad88a9dbc9e4646314d6

To test this change/fix you can download the above artifact file, unzip it, and run it.

Please make sure to quit your existing Nextcloud app and backup your data.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 31, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
Image D Maintainability Rating on New Code (required ≥ A)
Image 7 New Code Smells (required ≤ 0)

See analysis details on SonarQube Cloud

Image Catch issues before they fail your Quality Gate with our IDE extension Image SonarQube for IDE

@mgallien mgallien merged commit 8027bcc into master Jul 31, 2025
17 of 18 checks passed
@mgallien mgallien deleted the fix/logger/temp-logdir-permis branch July 31, 2025 13:49
@mgallien
Copy link
Collaborator

mgallien commented Aug 1, 2025

/backport to stable-3.17

@backportbot backportbot bot mentioned this pull request Aug 1, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mgallien mgallien mgallien approved these changes

@camilasan camilasan Awaiting requested review from camilasan camilasan is a code owner

@claucambra claucambra Awaiting requested review from claucambra

@nilsding nilsding Awaiting requested review from nilsding nilsding is a code owner

@i2h3 i2h3 Awaiting requested review from i2h3 i2h3 is a code owner

Assignees

No one assigned

Labels

2. developing

Projects

None yet

Milestone

3.17.0

Development

Successfully merging this pull request may close these issues.

5 participants

@joshtrichards @Rello @mgallien @camilasan