File Provider Localization #8507
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
i2h3
force-pushed
the
feature/file-provider-localization
branch
5 times, most recently
from
0287607 to
d25a6cc
Compare
i2h3
force-pushed
the
feature/file-provider-localization
branch
from
d25a6cc to
2001c77
Compare
i2h3
force-pushed
the
feature/file-provider-localization
branch
from
2001c77 to
4802004
Compare
…r UI extensions. Signed-off-by: Iva Horn <[email protected]>
i2h3
force-pushed
the
feature/file-provider-localization
branch
from
a438cb9 to
c78bd2f
Compare
|
Artifact containing the AppImage: nextcloud-appimage-pr-8507.zip SHA256 checksum: To test this change/fix you can download the above artifact file, unzip it, and run it. Please make sure to quit your existing Nextcloud app and backup your data. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements localization for the macOS File Provider integration by replacing hardcoded string literals with localized string resources. The change enables internationalization support for the File Provider extension and UI components.
- Replace hardcoded English strings with
String(localized:)calls across Swift files - Add
Localizable.xcstringsfiles for both FileProviderExt and FileProviderUIExt modules - Update Xcode project configuration to enable localization and add German translations
Reviewed Changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| project.pbxproj | Added localization resource files to build targets and enabled Swift localization strings |
| ShareViewController.swift | Replaced hardcoded strings with localized equivalents for UI labels and error messages |
| ShareTableViewDataSource.swift | Localized error messages and user-facing text |
| ShareTableItemView.swift | Localized accessibility descriptions |
| ShareOptionsView.swift | Localized UI element titles and placeholders |
| LockViewController.swift | Localized lock/unlock status messages and button titles |
| Localizable.xcstrings (FileProviderUIExt) | Added comprehensive localization dictionary with German translations |
| Localizable.xcstrings (FileProviderExt) | Added basic localization dictionary for file provider strings |
| .tx/config | Updated Transifex configuration to include new localization resources |
shell_integration/MacOSX/NextcloudIntegration/FileProviderUIExt/Localizable.xcstrings
Show resolved
Hide resolved
shell_integration/MacOSX/NextcloudIntegration/FileProviderUIExt/Localizable.xcstrings
Show resolved
Hide resolved
nilsding
reviewed
Aug 1, 2025
shell_integration/MacOSX/NextcloudIntegration/FileProviderUIExt/Sharing/ShareOptionsView.swift
Show resolved
Hide resolved
shell_integration/MacOSX/NextcloudIntegration/NextcloudIntegration.xcodeproj/project.pbxproj
Show resolved
Hide resolved
mgallien
approved these changes
Aug 1, 2025
|
Member
|
/backport to stable-3.17 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces #8489 which was unintentionally closed automatically as a side effect of renaming its branch to enable builds in our brander.