-
Notifications
You must be signed in to change notification settings - Fork 898
feat: More modern status icons #8554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
neat! What's the plan for the coloured status icons (e.g. theme/colored/state-ok.svg)? As of now they are used for the systray icon by default, and appear in a couple of places within the UI as well (systray window, account settings, ...) |
I think they are fine to stay as-is. As long as the metaphors don't diverge, they should be fine as custom ones. |
|
Hmm, although I could try how they look with the same shape. Let me see. |
8a1d7ac to
e197240
Compare
|
Hello @kra-mo, thank you for getting involved in the UI part of the desktop client. While I agree, that the icons need to be reworked, the proposed icons so not match Nextcloud. Challenge is, icons cannot be replaced that easily, as this has an impact on the branding/whitelabeling for enterprise customers. |
These are just (slightly tweaked) Material Symbols, we use them across the product. In any case, the current ones have actual issues, such as lacking contrast. The proposed ones definitely don't look less in style than the status quo and they don't really have more branding. I'd think they're an improvement in any case. I could just have the Nextcloud logo with badges or similar I suppose but I wouldn't want to cheapen our brand by using the logo everywhere. This is for a different thing though, right? That could just be the logo. |
|
I could also remove the cloud shape and just use generic circular icons that are still more modern, although I think a cloud is a cloud and it wouldn't have a negative impact to have it. |
I second that. It reminds me too much of OneDrive. The Nextcloud brand does not appear clearly enough. I guess the Nextcloud logo itself is not an option to augment with details like a checkmark or cross mark, especially on low-resolution displays where the details would be lost in pixelation. |
Taken from Material Symbols, plus some custom ones that fit the style. Signed-off-by: kramo <[email protected]>
e197240 to
fc0ccf9
Compare
|
One question is: Are these icons used as the folder badges? In that case, it'd be better to have separate assets for those. |
|
Artifact containing the AppImage: nextcloud-appimage-pr-8554.zip SHA256 checksum: To test this change/fix you can download the above artifact file, unzip it, and run it. Please make sure to quit your existing Nextcloud app and backup your data. |
|
|
Hello, I just wanted to chime in and say that I feel like these updated new icons are not really an upgrade compared to the current white-label tray indicators. I very well understand that the first suggestion looked a lot like OneDrive, but I feel like the heavy Nextcloud logo usage in the newly proposed icon set feels overwhelming and not super professional. I feel like the massive Nextcloud logo
In general, the indicators look great, especially the swapping of the exclamation mark for a triangle in the b/w variant is a clever way to work with the constraints! What do you think? |
|
I see the disadvantage for the very small status indicator. Perhaps we can make it bigger with even overlapping the NC icon a little? @kra-mo here is how it looks on macOS
Status:In App
|
|
Let me preface this by saying that I think system tray et al. is a terrible pattern and I wish it did not exist. (In favor of notifications, proper indication of running background apps, etc.) I do also share some of your sentiments.
Keep in mind that only a single one will be visible at a time and that these icons will be tiny in any case. With that in mind, I don't think this would be an issue.
Unfortunately yes, this is just one of the limitations of the tray. But look at many other solutions and see that they arrived at the same conclusion: The big logo, to be distinguishable from other tray icons (as users may have many) and a small status icon. |
I tried that, but it did not work well. It didn't give much more context and made the logo less recognizable.
Looks fine to me.
That should maybe use another icon then? Not sure how that would be done, I'm not a Qt developer, maybe it could be done in a follow-up? Also for folder status icons in the file manager, in case this icon is used, it probably should not be. I can provide assets for a PR that would depend on this (or just pushing to this branch), but as again, I'm not a developer, someone would have to do it :) |
Hi, I did think about something like this, but editing the logo in this way is generally not a good idea and in our case, explicitly recommended against:
From our brand guidelines. |
|
Yes please add the logos from here #8554 (comment) Also i like to mention: nextcloud/client_theming#196 (comment) |
I agree these logos look amazing! Time for a change! |
|
I will be evaluating brander impact the next day as a precondition to merge this PR.... |
Thanks so much for considering this, @Rello. Personally, I think this is a great step toward giving Nextcloud a more modern and refined look |
|
Hello, for dependency reasons with the brander related changes, this PR has to continue here: https://github.com/nextcloud/desktop/pull/8691/files all icons were taken over already |
|
the other PR was merged |
@Rello I am sorry, but why are you trying to 'advertise' to people who are already using Nextcloud? It is "Verschlimmbessern". If people are already using Nextcloud, the team should not try to make it less user friendly. |
But this is not what was implemented |












Taken from Material Symbols, plus some custom ones that fit the style.