Skip to content

fix(quota): return unlimited free space for type changes. #8561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mgallien merged 9 commits into from
Aug 13, 2025
Merged

fix(quota): return unlimited free space for type changes. #8561

mgallien merged 9 commits into from
Aug 13, 2025
+120 −10

Conversation

@camilasan
Copy link
Member

@camilasan camilasan commented Aug 11, 2025 •
edited by mgallien
Loading

Close #8555

@camilasan camilasan added this to the 3.17.0 milestone Aug 11, 2025
@camilasan camilasan marked this pull request as ready for review August 11, 2025 18:46
@camilasan
Copy link
Member Author

camilasan commented Aug 11, 2025

/backport to stable-3.17

@camilasan camilasan mentioned this pull request Aug 11, 2025
Closed
8 tasks
mgallien
mgallien requested changes Aug 12, 2025
View reviewed changes
Copy link
Collaborator

@mgallien mgallien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I realize that our testing coverage is probably not good enough because you did not modified any test
work to be done later I guess

nilsding
nilsding requested changes Aug 12, 2025
View reviewed changes
@camilasan camilasan force-pushed the bugfix/dbquota branch 2 times, most recently from 57e2404 to da3d3d1 Compare August 12, 2025 20:57
mgallien
mgallien requested changes Aug 13, 2025
View reviewed changes
Copy link
Collaborator

@mgallien mgallien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see my comments about new files

nilsding
nilsding approved these changes Aug 13, 2025
View reviewed changes
@camilasan @mgallien
fix(quota): return unlimited free space for type changes.
40ecd90 
Signed-off-by: Camila Ayres <[email protected]>
@camilasan @mgallien
feat(syncjournaldb): add default value to quotaBytesAvailable and quo…
1fc1d7b 
…taBytesUsed columns.

Fix for #8555.

Signed-off-by: Camila Ayres <[email protected]>
@camilasan @mgallien
test(syncjournaldb): folder quota default values.
95d7e54 
Signed-off-by: Camila Ayres <[email protected]>
@camilasan @mgallien
feat(quota): add default value to metadata column if it doesn't exist.
af3ee7c 
Signed-off-by: Camila Ayres <[email protected]>
@camilasan @mgallien
refactor(syncjournaldb): move removeColumn lambda to a function.
de4f607 
Signed-off-by: Camila Ayres <[email protected]>
@camilasan @mgallien
refactor(syncjournaldb): move hasDefaultValue lambda to a function.
0a320a5 
Signed-off-by: Camila Ayres <[email protected]>
@camilasan @mgallien
refactor(syncjournaldb): refactor logic before updating the list of c…
cd2fc99 
…olumns when removing one.

Signed-off-by: Camila Ayres <[email protected]>
@camilasan @mgallien
test(syncjournaldb): add test for migrating folder quota columns.
17001c6 
For upgrading from 3.17 release candidate to final.

Signed-off-by: Camila Ayres <[email protected]>
@camilasan @nilsding
test(syncjournaldb): use QCOMPARE_GT.
d28dbb7 
Co-authored-by: Jyrki Gadinger <[email protected]>
Signed-off-by: Camila Ayres <[email protected]>
@github-actions
Copy link

github-actions bot commented Aug 13, 2025

Artifact containing the AppImage: nextcloud-appimage-pr-8561.zip

SHA256 checksum: bbe60b07b7145ca0fc9ca1908c0431cc9a43de518aaa1b02cce70000ea5e6590

To test this change/fix you can download the above artifact file, unzip it, and run it.

Please make sure to quit your existing Nextcloud app and backup your data.

@mgallien mgallien merged commit decf1e7 into master Aug 13, 2025
17 checks passed
@mgallien mgallien deleted the bugfix/dbquota branch August 13, 2025 09:02
@backportbot backportbot bot mentioned this pull request Aug 13, 2025
Merged
@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 13, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
Image 73 New Code Smells (required ≤ 0)
Image D Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Image Catch issues before they fail your Quality Gate with our IDE extension Image SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mgallien mgallien mgallien approved these changes

@nilsding nilsding nilsding approved these changes

@i2h3 i2h3 Awaiting requested review from i2h3 i2h3 is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

3.17.0

Development

Successfully merging this pull request may close these issues.

Bug Report: Upload fails due to incorrect quota check in version 3.17.0-20250805

4 participants

@camilasan @mgallien @nilsding