Skip to content

feat: set LocalizedResourceName for sync folders. #8585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
camilasan merged 2 commits into from
Aug 18, 2025
Merged

feat: set LocalizedResourceName for sync folders. #8585

camilasan merged 2 commits into from
Aug 18, 2025

Conversation

@camilasan
Copy link
Member

@camilasan camilasan commented Aug 14, 2025 •
edited
Loading

  • Before folders Nextcloud and Nextcloud2 (client 3.14.4) -
Screenshot_20250814_114630
  • After folder NextcloudDev and NextcloudDev2 -
Screenshot_20250814_153546

@camilasan camilasan added this to the 3.17.1 milestone Aug 14, 2025
@camilasan camilasan force-pushed the bugfix/syncfolderdisplay branch from 4f8e598 to e086aeb Compare August 14, 2025 15:05
@camilasan camilasan marked this pull request as ready for review August 14, 2025 15:05
@camilasan camilasan force-pushed the bugfix/syncfolderdisplay branch from e086aeb to cd603cd Compare August 14, 2025 18:20
@mgallien mgallien force-pushed the bugfix/syncfolderdisplay branch from cd603cd to d60c760 Compare August 18, 2025 09:22
@github-actions
Copy link

github-actions bot commented Aug 18, 2025

Artifact containing the AppImage: nextcloud-appimage-pr-8585.zip

SHA256 checksum: fbc8ac2b923a1e265f61d13e1a2f4d2ca42599fbfafb19138de134d64a32f985

To test this change/fix you can download the above artifact file, unzip it, and run it.

Please make sure to quit your existing Nextcloud app and backup your data.

@mgallien
Copy link
Collaborator

mgallien commented Aug 18, 2025

/backport to stable-3.17

@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 18, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
Image 0.0% Coverage on New Code (required ≥ 80%)
Image C Maintainability Rating on New Code (required ≥ A)
Image 15 New Code Smells (required ≤ 0)

See analysis details on SonarQube Cloud

Image Catch issues before they fail your Quality Gate with our IDE extension Image SonarQube for IDE

@camilasan camilasan merged commit 6cbccf5 into master Aug 18, 2025
18 of 20 checks passed
@camilasan camilasan deleted the bugfix/syncfolderdisplay branch August 18, 2025 12:15
@backportbot backportbot bot mentioned this pull request Aug 18, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nilsding nilsding nilsding approved these changes

@i2h3 i2h3 Awaiting requested review from i2h3 i2h3 is a code owner

@mgallien mgallien Awaiting requested review from mgallien mgallien is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

3.17.1

Development

Successfully merging this pull request may close these issues.

4 participants

@camilasan @mgallien @nilsding