fix(activityItemContent): make text color light on activityItem activeFocus #8676
Conversation
barisbasar1209
requested review from
camilasan,
i2h3,
mgallien and
nilsding
as code owners
|
@barisbasar1209 I am sorry for the current delay with the reviews |
|
@mgallien No problem at all. Thank you for the invitation, I appreciate it a lot! Unfortunately I won't be able to come as I am traveling outside Germany during this time. Otherwise I would've loved to participate. |
…eFocus Co-authored-by: Mike Mengjie Huang <[email protected]> Signed-off-by: Baris <[email protected]>
|
Artifact containing the AppImage: nextcloud-appimage-pr-8676.zip Digest: To test this change/fix you can download the above artifact file, unzip it, and run it. Please make sure to quit your existing Nextcloud app and backup your data. |
|
/backport to stable-3.17 |
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
3 participants
This PR by @mike0609king and me proposes a fix for issue #8221.
Previously: When an activityitem is in focus its color changes to the classical nextcloud-blue. In light-mode this makes the contenttext harder to read due to its black color.
Change: When the activityitem is in focus its contenttext color adapts to a lighter one.
Here are images from windows 10 and windows 11 to demonstrate the changes. Thanks for the review!
Windows 10 before:
Windows 10 now:
Windows 11 before:
Windows 11 now:
(For some reason there is this black frame around the activity here, when it is in focus. This appears to be unrelated to the code changes, as it is also present on this machine while executing the current desktop client version. The before image is taken from the issue's original post.)
Remark: We are aware that on windows10 the fileDetailsButton (the three-dots button) still looks a bit odd. We tried making it adapt its color to a lighter one when the activityitem is in focus. However, the only way this seemed achievable was by setting the fileDetailsButton-item's background. But this would alter the appearence for other styles such as that for windows11 significantly, causing the button to look unnatural within the style. For this reason we decided to keep it as it is.
If there are any good suggestions on how this can be achieved without interfering with the other styles, we'd appreciate it a lot.