fix(encryption/token): try to init the token again after errors #8724
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgallien
force-pushed
the
bugfix/usbTokenReconnect
branch
from
be20ecb to
1b9c095
Compare
mgallien
force-pushed
the
bugfix/usbTokenReconnect
branch
from
1f4878a to
aaa7095
Compare
nilsding
reviewed
Sep 11, 2025
mgallien
force-pushed
the
bugfix/usbTokenReconnect
branch
2 times, most recently
from
1d36765 to
48e6058
Compare
nilsding
approved these changes
Sep 11, 2025
mgallien
force-pushed
the
bugfix/usbTokenReconnect
branch
from
48e6058 to
64ff75d
Compare
Collaborator
Author
|
seems broken again |
mgallien
force-pushed
the
bugfix/usbTokenReconnect
branch
2 times, most recently
from
16d8796 to
78ba1f7
Compare
mgallien
force-pushed
the
bugfix/usbTokenReconnect
branch
from
78ba1f7 to
d76fb31
Compare
mgallien
force-pushed
the
bugfix/usbTokenReconnect
branch
from
d76fb31 to
fa63283
Compare
mgallien
added
3. to review
feature: 🔒 end to end encryption
and removed
2. developing
labels
mgallien
force-pushed
the
bugfix/usbTokenReconnect
branch
from
fa63283 to
3ce8afd
Compare
nilsding
approved these changes
Sep 30, 2025
will enable token automated recovery in case of errors Signed-off-by: Matthieu Gallien <[email protected]>
if the client looses the connection with the USB secure token, we need to setup the session again and retry teh encryption or decryption operation Signed-off-by: Matthieu Gallien <[email protected]>
should better detect when the USB token session is broken and needs a reset Signed-off-by: Matthieu Gallien <[email protected]>
we need to destroy all handles to any resources before the pkcs#11 library context is destroyed itself to avoid wrong memory access Signed-off-by: Matthieu Gallien <[email protected]>
mgallien
force-pushed
the
bugfix/usbTokenReconnect
branch
from
3ce8afd to
9e6e967
Compare
|
Artifact containing the AppImage: nextcloud-appimage-pr-8724.zip Digest: To test this change/fix you can download the above artifact file, unzip it, and run it. Please make sure to quit your existing Nextcloud app and backup your data. |
|
Member
|
/backport to stable-3.17 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.