fix: log - BasicControls for better customization. #8762
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rello
requested review from
camilasan,
i2h3,
mgallien and
nilsding
as code owners
Collaborator
|
we might want to have a screenshot of before and after to check |
nilsding
approved these changes
Sep 17, 2025
Member
nilsding
left a comment
nilsding
left a comment
There was a problem hiding this comment.
LGTM, looks exactly the same on Linux with the Breeze style
mgallien
approved these changes
Sep 17, 2025
Collaborator
mgallien
left a comment
mgallien
left a comment
There was a problem hiding this comment.
tested
seems to work fine
Rello
force-pushed
the
bugfix/BasicControls
branch
from
8533f57 to
c32a1c7
Compare
i2h3
approved these changes
Sep 17, 2025
> QML QQuickRectangle: The current style does not support customization of this control (property: "background" item: QQuickRectangle(0x600003e89dc0, parent=0x0, geometry=0,0 0x0)). Please customize a non-native style (such as Basic, Fusion, Material, etc). For more information, see: https://doc.qt.io/qt-6/qtquickcontrols2-customize.html#customization-reference > QML QQuickItem: The current style does not support customization of this control (property: "contentItem" item: QQuickItem(0x600003e8a220, parent=0x0, geometry=0,0 0x0)). Please customize a non-native style (such as Basic, Fusion, Material, etc). For more information, see: https://doc.qt.io/qt-6/qtquickcontrols2-customize.html#customization-reference Updated NCProgressBar to instantiate the Basic Controls implementation so its customized background and content items render without native style warnings Signed-off-by: Rello <[email protected]>
Rello
force-pushed
the
bugfix/BasicControls
branch
from
c32a1c7 to
67b498b
Compare
|
Artifact containing the AppImage: nextcloud-appimage-pr-8762.zip Digest: To test this change/fix you can download the above artifact file, unzip it, and run it. Please make sure to quit your existing Nextcloud app and backup your data. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated NCProgressBar to instantiate the Basic Controls implementation so its customized background and content items render without native style warnings