Skip to content

Conversation

@Aiiaiiio
Copy link
Collaborator

Fixes: #8496

image

@Aiiaiiio Aiiaiiio requested a review from nilsding September 22, 2025 11:22
@nilsding nilsding force-pushed the bugfix/empty-share-link-copy-button branch from b777057 to 74ac56d Compare September 22, 2025 13:03
Copy link
Member

@nilsding nilsding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

also, when updating the branch please rebase it on top of master. I just did that for this PR

@mgallien mgallien force-pushed the bugfix/empty-share-link-copy-button branch from 74ac56d to 11e797c Compare September 23, 2025 07:04
@github-actions
Copy link

Artifact containing the AppImage: nextcloud-appimage-pr-8785.zip

Digest: sha256:ecbd162fc8f9f2c2357ce5fe0d765c19ac8fbebbe0a6673e05473b970c0067db

To test this change/fix you can download the above artifact file, unzip it, and run it.

Please make sure to quit your existing Nextcloud app and backup your data.

@sonarqubecloud
Copy link

@Aiiaiiio Aiiaiiio merged commit 00a4462 into master Sep 23, 2025
19 checks passed
@Aiiaiiio Aiiaiiio deleted the bugfix/empty-share-link-copy-button branch September 23, 2025 07:39
@github-actions
Copy link

github-actions bot commented Oct 7, 2025

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

@camilasan
Copy link
Member

/backport to stable-3.17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Copying internal link / creating public link - indicator that the link gets generated is broken

4 participants