File Provider Fix: Translated Some Texts #8966
Conversation
i2h3
requested review from
Aiiaiiio,
camilasan,
mgallien and
nilsding
as code owners
… user interface. Signed-off-by: Iva Horn <[email protected]>
Signed-off-by: Iva Horn <[email protected]>
Signed-off-by: Iva Horn <[email protected]>
Signed-off-by: Iva Horn <[email protected]>
i2h3
force-pushed
the
fix/9686105-localization
branch
from
416b609 to
2feb707
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR fixes missing localization in the File Provider UI by ensuring localized strings are applied when the share view is initialized. The key change extracts localization code into a separate method and calls it during view setup.
Key Changes
- Extracted localization logic into a dedicated
applyLocalizedStrings()method inShareOptionsView - Added call to
applyLocalizedStrings()inShareViewController.viewDidLoad()to ensure strings are localized on initialization - Added Danish translations and new string keys to the localization catalog
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| shell_integration/MacOSX/NextcloudIntegration/README.md | Removed obsolete cleanup instructions section |
| shell_integration/MacOSX/NextcloudIntegration/FileProviderUIExt/Sharing/ShareViewController.swift | Added call to apply localized strings during view initialization |
| shell_integration/MacOSX/NextcloudIntegration/FileProviderUIExt/Sharing/ShareOptionsView.swift | Refactored localization code into separate public method |
| shell_integration/MacOSX/NextcloudIntegration/FileProviderUIExt/Localizable.xcstrings | Added Danish translations and new localization keys |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
/backport to stable-4.0 |
|
Artifact containing the AppImage: nextcloud-appimage-pr-8966.zip Digest: To test this change/fix you can download the above artifact file, unzip it, and run it. Please make sure to quit your existing Nextcloud app and backup your data. |
|
Just a code call was missing for applying some localized string.