fix(migration): set all settings and keychain keys from the previous version of the client. #8969
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camilasan
requested review from
Aiiaiiio,
i2h3,
mgallien and
nilsding
as code owners
camilasan
force-pushed
the
bugfix/general-settings
branch
from
f8a9ce2 to
850ad86
Compare
Member
Author
|
/backport to stable-3.17 |
Member
Author
|
/backport to stable-4.0 |
nilsding
reviewed
Oct 28, 2025
camilasan
force-pushed
the
bugfix/general-settings
branch
3 times, most recently
from
6002883 to
0f5daa4
Compare
camilasan
force-pushed
the
bugfix/general-settings
branch
from
0f5daa4 to
432619a
Compare
nilsding
approved these changes
Nov 4, 2025
camilasan
force-pushed
the
bugfix/general-settings
branch
4 times, most recently
from
0ca5903 to
79b8d83
Compare
camilasan
changed the title
camilasan
changed the title
mgallien
force-pushed
the
bugfix/general-settings
branch
from
3b54016 to
70a2e36
Compare
camilasan
force-pushed
the
bugfix/general-settings
branch
3 times, most recently
from
0570b90 to
9255969
Compare
…ent. - Change variable names for more readable ones. - Related to PRs #8706 and #8925. Signed-off-by: Camila Ayres <[email protected]>
Signed-off-by: Camila Ayres <[email protected]>
… user proxy. Signed-off-by: Camila Ayres <[email protected]>
Signed-off-by: Camila Ayres <[email protected]>
…keychain key name. Signed-off-by: Camila Ayres <[email protected]>
… the keychain keys. - Modernize function AbstractCredentials::keychainkey. - Add string to save current or legacy application name. Signed-off-by: Camila Ayres <[email protected]>
Signed-off-by: Camila Ayres <[email protected]>
…on steps. Signed-off-by: Camila Ayres <[email protected]>
Signed-off-by: Camila Ayres <[email protected]>
Signed-off-by: Camila Ayres <[email protected]>
Signed-off-by: Camila Ayres <[email protected]>
…ame. Remove emit signal call: it would trigger the call for saveAccountHelper() which in turn would call persist() again. Signed-off-by: Camila Ayres <[email protected]>
Signed-off-by: Camila Ayres <[email protected]>
…us version of the client. Enabled/disable the checkbox when changing the server notifications setting. Signed-off-by: Camila Ayres <[email protected]>
camilasan
force-pushed
the
bugfix/general-settings
branch
from
9255969 to
2bc2bbb
Compare
Only valid for Windows. Signed-off-by: Camila Ayres <[email protected]>
|
Artifact containing the AppImage: nextcloud-appimage-pr-8969.zip Digest: To test this change/fix you can download the above artifact file, unzip it, and run it. Please make sure to quit your existing Nextcloud app and backup your data. |
github-project-automation
bot
moved this from 🏗️ In progress
to ☑️ Done
in 💻 Desktop Clients team
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to solve two issues:
General settings and general network from older versions are not correctly migrated to newer versions.
Some general settings items were not take into consideration when loading the settings again for the new version. Now all are read and set in the new client version.
After migration the client does not recognize the older keychain keys and it asks the user to reconnect.
After setting the new client settings, the fetching from keychain process was not taking into consideration that the previous version of the client might have had a different name.
In this PR I have added a enum to track the migration steps, so when it gets to the step of fetching the keychain keys, it will check if a migration is in progress and use the legacy app name or if should proceed with the current app name.
Related to
Before
After