fix(gui): initialise e2e()->account() from Account #9031
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nilsding
requested review from
Aiiaiiio,
camilasan,
i2h3 and
mgallien
as code owners
camilasan
approved these changes
Nov 17, 2025
Member
|
/backport to stable-3.17 |
Member
|
/backport to stable-4.0 |
camilasan
force-pushed
the
bugfix/noid/e2e-account-init
branch
from
0f17368 to
b1f2675
Compare
This resolves a crash when opening the settings window in case the ConnectionValidator already reported a Connected status, but is still busy fetching the user info. Added a test to ensure the constructor no longer crashes with this fix. I hope this works fine in CI 🤞 Signed-off-by: Jyrki Gadinger <[email protected]>
…lding a VFS client Ironically enough, a VFS/File Provider client build crashes on this test when run in CI. I'm not yet sure what's causing it as it works fine in a non-VFS build... Signed-off-by: Jyrki Gadinger <[email protected]>
camilasan
force-pushed
the
bugfix/noid/e2e-account-init
branch
from
b1f2675 to
7cf8a58
Compare
|
Artifact containing the AppImage: nextcloud-appimage-pr-9031.zip Digest: To test this change/fix you can download the above artifact file, unzip it, and run it. Please make sure to quit your existing Nextcloud app and backup your data. |
|
This was referenced Nov 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves a crash when opening the settings window in case the ConnectionValidator already reported a Connected status, but is still busy fetching the user info. I guess this is what still happened in #8710 as well, but without logs I can't be sure if it resolves that one as well.
Added a test to ensure the constructor no longer crashes with this change. I hope this works fine in CI 🤞