Improved File Provider Locking Overlay Layout in Finder #9059
+29
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
i2h3
requested review from
Aiiaiiio,
camilasan,
mgallien and
nilsding
as code owners
github-project-automation
bot
moved this to 🧭 Planning evaluation (don't pick)
in 💻 Desktop Clients team
i2h3
force-pushed
the
i2h3/chore/locking-overlay-improvements
branch
from
117b4b3 to
32a615d
Compare
|
Artifact containing the AppImage: nextcloud-appimage-pr-9059.zip Digest: To test this change/fix you can download the above artifact file, unzip it, and run it. Please make sure to quit your existing Nextcloud app and backup your data. |
i2h3
force-pushed
the
i2h3/chore/locking-overlay-improvements
branch
from
32a615d to
82e53df
Compare
Collaborator
Author
|
/backport to stable-4.0 |
- Mostly, I removed redundant and unnecessary constraints. - Increased spacing around user interface elements to give it more room to breath, screen space is ample here. - Consolidated fonts used. Signed-off-by: Iva Horn <[email protected]>
i2h3
force-pushed
the
i2h3/chore/locking-overlay-improvements
branch
from
82e53df to
721fb38
Compare
github-project-automation
bot
moved this from 🧭 Planning evaluation (don't pick)
to ☑️ Done
in 💻 Desktop Clients team
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit message.
Requires #9058 to be merged first.
/backport to stable-4.0