Skip to content

Conversation

@camilasan
Copy link
Member

Consider that an empty previous client version is also an upgrade as long as the app running has a different version of the client version saved in the config file.

@camilasan
Copy link
Member Author

/backport to stable-3.17

@camilasan
Copy link
Member Author

/backport to stable-4.0

@camilasan camilasan added this to the 4.0.4 milestone Dec 8, 2025
@camilasan camilasan force-pushed the bugfix/noid/clientversion branch from 5958556 to c0b4c6f Compare December 8, 2025 19:00
@camilasan camilasan changed the title fix(upgrade): set later the previous client version. fix(upgrade): set the previous client version after the upgrade check. Dec 8, 2025
@mgallien mgallien enabled auto-merge December 9, 2025 08:44
Consider that an empty previous client version is also an upgrade as
long as the app running has a different version of the client
version saved in the config file.

Signed-off-by: Camila Ayres <[email protected]>
@mgallien mgallien force-pushed the bugfix/noid/clientversion branch from c0b4c6f to 9d2b6e6 Compare December 9, 2025 08:44
@github-actions
Copy link

github-actions bot commented Dec 9, 2025

Artifact containing the AppImage: nextcloud-appimage-pr-9204.zip

Digest: sha256:fcbbd5318f62975696b4675715cec45f47b36ea6821b7808291f6eee3582e263

To test this change/fix you can download the above artifact file, unzip it, and run it.

Please make sure to quit your existing Nextcloud app and backup your data.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 9, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
Image D Security Rating on New Code (required ≥ A)
Image 80 New Code Smells (required ≤ 0)
Image E Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Image Catch issues before they fail your Quality Gate with our IDE extension Image SonarQube for IDE

@mgallien mgallien merged commit bd1fe2d into master Dec 9, 2025
21 of 22 checks passed
@mgallien mgallien deleted the bugfix/noid/clientversion branch December 9, 2025 09:28
@mgallien mgallien modified the milestones: 4.0.4, 4.1.0 Dec 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants