fix(accessmanager): manually handle redirects #9247
Merged
+168
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since Qt 6 the default redirection policy is `NoLessSafeRedirectPolicy`. This resulted in the `QNetworkReply::redirected` signal to never be emitted. Signed-off-by: Jyrki Gadinger <[email protected]>
Signed-off-by: Jyrki Gadinger <[email protected]>
Signed-off-by: Jyrki Gadinger <[email protected]>
nilsding
requested review from
Aiiaiiio,
camilasan,
i2h3 and
mgallien
as code owners
|
Artifact containing the AppImage: nextcloud-appimage-pr-9247.zip Digest: To test this change/fix you can download the above artifact file, unzip it, and run it. Please make sure to quit your existing Nextcloud app and backup your data. |
mgallien
approved these changes
Dec 15, 2025
Collaborator
|
/backport to stable-4.0 |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Qt 6 the default redirection policy is
NoLessSafeRedirectPolicy. This resulted in the custom redirect logic inAbstractNetworkJob::slotFinishednever being used (this one already takes care of checking for HTTPS->HTTP downgrades, and if HSTS is enabled for the given host the request would be sent as HTTPS anyway).