document SSE-C support in external storage #12530
Conversation
AndyScherzinger
force-pushed
the
master
branch
from
bf80635 to
6655969
Compare
AndyScherzinger
left a comment
AndyScherzinger
left a comment
There was a problem hiding this comment.
Looks good to me, the screenshot of the settings right below the section should then probably be updated to with a light themed screenshot.
Other than that 👍
|
/backport to stable31 |
|
/backport to stable30 |
|
/backport to stable29 |
relates to nextcloud/server#33283 Signed-off-by: Christian Becker <[email protected]>
|
updated the screenshot. do you prefer it empty or prefilled with some values? |
AndyScherzinger
left a comment
AndyScherzinger
left a comment
There was a problem hiding this comment.
Looks good to me. I think empty is fine 👍
|
Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/documentation/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22 |
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
3 participants
Fix nextcloud/server#33283
Feature PR: nextcloud/server#50326