Skip to content

fix(notifications): Notifier::prepare() threw \InvalidArgumentExcepti… #1466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
juliusknorr merged 1 commit into from
Dec 27, 2024
Merged

fix(notifications): Notifier::prepare() threw \InvalidArgumentExcepti… #1466

juliusknorr merged 1 commit into from
Dec 27, 2024

Conversation

@nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Dec 20, 2024

…on which is deprecated

If a user has any notifications this log is generated all the time:

OCA\…\Notification\Notifier::prepare() threw \InvalidArgumentException which is deprecated. Throw \OCP\Notification\UnknownNotificationException when the notification is not known to your notifier and otherwise handle all \InvalidArgumentException yourself.

@nickvergessen nickvergessen self-assigned this Dec 20, 2024
@juliusknorr juliusknorr merged commit 3f2eb76 into master Dec 27, 2024
45 checks passed
@juliusknorr juliusknorr deleted the bugfix/noid/notification-handling branch December 27, 2024 08:04
@skjnldsv skjnldsv mentioned this pull request Jan 7, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@juliusknorr juliusknorr juliusknorr approved these changes

@Pytal Pytal Awaiting requested review from Pytal

Assignees

@nickvergessen nickvergessen

Labels

3. to review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nickvergessen @juliusknorr