Skip to content

fix(notifications): Fix notification parameter types #2041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
provokateurin merged 1 commit into from
Sep 16, 2024
Merged

fix(notifications): Fix notification parameter types #2041

provokateurin merged 1 commit into from
Sep 16, 2024

Conversation

@nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Sep 16, 2024

  • Fix psalm
  • Require Psalm on CI

@nickvergessen nickvergessen self-assigned this Sep 16, 2024
@nickvergessen
Copy link
Member Author

nickvergessen commented Sep 16, 2024

/backport to stable30

@github-actions
Copy link
Contributor

github-actions bot commented Sep 16, 2024

🐢 Performance warning.
It looks like the query count of the integration tests increased with this PR.
Database query count is now 8731 was 8200 (+6.47%)
Please check your code again. If you added a new test this can be expected and the base value in tests/Integration/base-query-count.txt can be increased.

@provokateurin provokateurin merged commit 880a19e into master Sep 16, 2024
@provokateurin provokateurin deleted the bugfix/2035/notification-data branch September 16, 2024 14:04
@backportbot backportbot bot mentioned this pull request Sep 16, 2024
Merged
@skjnldsv skjnldsv mentioned this pull request Jan 7, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@provokateurin provokateurin provokateurin approved these changes

Assignees

@nickvergessen nickvergessen

Labels

3. to review bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nickvergessen @provokateurin