Skip to content

ci: Skip printing the log as we count the queries and upload it already #2356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nickvergessen merged 1 commit into from
May 20, 2025
Merged

ci: Skip printing the log as we count the queries and upload it already #2356

nickvergessen merged 1 commit into from
May 20, 2025

Conversation

@nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented May 20, 2025 •
edited
Loading

@nickvergessen nickvergessen added this to the Nextcloud 32 milestone May 20, 2025
@nickvergessen nickvergessen self-assigned this May 20, 2025
SystemKeeper
SystemKeeper approved these changes May 20, 2025
View reviewed changes
Copy link
Contributor

@SystemKeeper SystemKeeper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine for removing the print, but needs to revert the branch before merging

@nickvergessen nickvergessen force-pushed the ci/noid/test-server-branch branch from feba157 to d862e90 Compare May 20, 2025 06:54
@nickvergessen nickvergessen enabled auto-merge May 20, 2025 06:54
@github-actions
Copy link
Contributor

github-actions bot commented May 20, 2025

🐢 Performance warning.
It looks like the query count of the integration tests increased with this PR.
Database query count is now 8900 was 8600 (+3.48%)
Please check your code again. If you added a new test this can be expected and the base value in tests/Integration/base-query-count.txt can be increased.

@nickvergessen nickvergessen merged commit 4c9287b into master May 20, 2025
47 checks passed
@nickvergessen nickvergessen deleted the ci/noid/test-server-branch branch May 20, 2025 06:58
@skjnldsv skjnldsv mentioned this pull request Aug 19, 2025
Merged
@skjnldsv skjnldsv modified the milestones: Nextcloud 32, Nextcloud 33 Sep 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SystemKeeper SystemKeeper SystemKeeper approved these changes

Assignees

@nickvergessen nickvergessen

Labels

3. to review

Projects

None yet

Milestone

Nextcloud 32

Development

Successfully merging this pull request may close these issues.

4 participants

@nickvergessen @SystemKeeper @skjnldsv