Skip to content

fix(notification): handle notification as an object prop #2396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Antreesy merged 4 commits into from
Jun 20, 2025
Merged

fix(notification): handle notification as an object prop #2396

Antreesy merged 4 commits into from
Jun 20, 2025

Conversation

@Antreesy
Copy link
Collaborator

@Antreesy Antreesy commented Jun 18, 2025

Extracted from #2395

  • replace v-bind with actual props
  • make ActionButton a decorative component (only accepts props and emit click events)
  • migrate ActionButton to script setup

To test actions:

  • WEB type: mention in chat, or start a call
  • POST/DELETE: federation invite (intercepted by Talk), share call recording

@Antreesy Antreesy added this to the Nextcloud 32 milestone Jun 18, 2025
@Antreesy Antreesy requested review from DorraJaouad and ShGKme June 18, 2025 09:59
@Antreesy Antreesy self-assigned this Jun 18, 2025
@Antreesy Antreesy requested a review from nickvergessen as a code owner June 18, 2025 09:59
DorraJaouad
DorraJaouad reviewed Jun 18, 2025
View reviewed changes
nickvergessen
nickvergessen reviewed Jun 20, 2025
View reviewed changes
ShGKme
ShGKme approved these changes Jun 20, 2025
View reviewed changes
Copy link
Contributor

@ShGKme ShGKme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@Antreesy Antreesy force-pushed the fix/noid/no-parent-prop branch from f36b171 to 33fb5fe Compare June 20, 2025 13:38
@Antreesy Antreesy force-pushed the fix/noid/no-parent-prop branch from 33fb5fe to 1e4263f Compare June 20, 2025 13:45
@Antreesy
Copy link
Collaborator Author

Antreesy commented Jun 20, 2025

/compile

@nextcloud-command
chore(assets): Recompile assets
5ba8497 
Signed-off-by: nextcloud-command <[email protected]>
@Antreesy Antreesy merged commit 7f468da into master Jun 20, 2025
41 checks passed
@Antreesy Antreesy deleted the fix/noid/no-parent-prop branch June 20, 2025 13:58
@skjnldsv skjnldsv mentioned this pull request Aug 19, 2025
Merged
@skjnldsv skjnldsv modified the milestones: Nextcloud 32, Nextcloud 33 Sep 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nickvergessen nickvergessen nickvergessen left review comments

@DorraJaouad DorraJaouad DorraJaouad left review comments

@ShGKme ShGKme ShGKme approved these changes

Assignees

@Antreesy Antreesy

Labels

3. to review feature: frontend 🖌️ technical debt

Projects

None yet

Milestone

Nextcloud 32

Development

Successfully merging this pull request may close these issues.

7 participants

@Antreesy @nickvergessen @ShGKme @DorraJaouad @skjnldsv @nextcloud-command