Deprecated event type for `OCP\IDBConnection::*`

[BenS89]

How to use GitHub

• Please use the 👍 reaction to show that you are affected by the same issue.
• Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
• Subscribe to receive notifications on status change and new comments.

Steps to reproduce

1. Upgrade from Nexcloud 19.0.5 to 20.0.2
2. Take a look into the logs

Expected behavior: no deprecation logs on info level

Current behavior: Multiple deprecation logs on info level

Deprecated event type for OCA\Files::loadAdditionalScripts: Symfony\Component\EventDispatcher\GenericEvent is used

Deprecated event type for {"[object] (OCP\SabrePluginEvent)":{"*statusCode":200,"*message":"","*server":{"[object] (OCA\DAV\Connector\Sabre\Server)":{"tree":"[object] (OCA\DAV\Connector\Sabre\ObjectTree)","*baseUri":"/remote.php/webdav/","httpResponse":"[object] (Sabre\HTTP\Response)","httpRequest":"[object] (Sabre\HTTP\Request)","sapi":"[object] (Sabre\HTTP\Sapi)","*plugins":[],"transactionType":null,"protectedProperties":{"...":"Over 20 items, aborting normalization"},"debugExceptions":false,"resourceTypeMapping":[],"enablePropfindDepthInfinity":true,"xml":"[object] (Sabre\DAV\Xml\Service)","*listeners":{"...":"Over 20 items, aborting normalization"},"*wildcardListeners":[],"*listenerIndex":[],"*logger":null}},"Symfony\Contracts\EventDispatcher\EventpropagationStopped":false}}: null

Deprecated event type for OCP\IDBConnection::CHECK_MISSING_PRIMARY_KEYS: Symfony\Component\EventDispatcher\GenericEvent is used

Deprecated event type for OCP\IDBConnection::CHECK_MISSING_INDEXES: Symfony\Component\EventDispatcher\GenericEvent is used

Deprecated event type for OCP\IDBConnection::CHECK_MISSING_COLUMNS: Symfony\Component\EventDispatcher\GenericEvent is used

[kesselb]

cc @ChristophWurst

That's on purpose right? (#18966 (comment))

[ChristophWurst]

yes

[ChristophWurst]

the updater switches to debug level logs, hence this shows.

[kesselb]

Log level for Deprecated event type for {name}: {class} is used is info.

[kesselb]

I guess we are not done with migrating everything yet. Shall we lower the log level to debug for now? (as we already did for 18).

[ChristophWurst]

ah. yeah, maybe. but also finally migrate those things 😉

[BenS89]

What´s the plan now? The log flooding on info level is indeed not optimal. Thanks for your feedback.

[stefanbenten]

I would also like to push this further. This is quite distracting from actual interesting log lines.

[ChristophWurst]

we have to migrate the code that uses the old events

I would also like to push this further.

I can give you pointers on where to look. But just open your IDE and see where the constant is used. Then you can replace the emitting and listening parts with a new event.

[User65481]

Any news on this? We're on 20.0.5.2 and have the same issue.

[ChristophWurst]

It's not fixed yet.

[User65481]

Any eta or any way on how we could help on this issue?
4 of our 5 most logged messages are caused by this bug:

(Side note: the other message, bind failed, is caused by another bug already reported on the android repo. 5 of 5 top messages are caused by bugs right now, making it more and more difficult to check logs and thus ensuring a stable environment)