Use random_bytes #20915
Merged
Use random_bytes #20915
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rullzer
requested review from
ChristophWurst,
MorrisJobke,
georgehrke and
nickvergessen
georgehrke
approved these changes
May 11, 2020
Since we don't care if it is human readbale. The code is backwards compatible with the old format. Signed-off-by: Roeland Jago Douma <[email protected]>
rullzer
force-pushed
the
enh/use_random_bytes_in_crypto
branch
from
421f78d to
35ff4aa
Compare
nickvergessen
approved these changes
May 11, 2020
Member
nickvergessen
left a comment
nickvergessen
left a comment
There was a problem hiding this comment.
Didn't test, but looks good.
Member
|
Backport till 17? |
Member
Author
sounds good! |
Member
Author
|
/backport to stable19 |
Member
Author
|
/backport to stable18 |
Member
Author
|
/backport to stable17 |
ChristophWurst
approved these changes
May 11, 2020
This was referenced May 11, 2020
Contributor
|
Glad to see this issue was fixed! :D |
6 tasks
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we don't care if it is human readbale.
The code is backwards compatible with the old format.
Signed-off-by: Roeland Jago Douma [email protected]