Skip to content

fix(carddav): Handle race for SAB creation better #42052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
skjnldsv merged 1 commit into from
Nov 6, 2024
Merged

fix(carddav): Handle race for SAB creation better #42052

skjnldsv merged 1 commit into from
Nov 6, 2024
+27 −7

Conversation

@ChristophWurst
Copy link
Member

@ChristophWurst ChristophWurst commented Dec 6, 2023 •
edited
Loading

Summary

  • Accept non repeatable read and INSERT conflict by another read
  • Handle replication edge case

This means the code is able to handle concurrency when writing, but is (still/again) vulnerable to read/write split timing problems.

Checklist

@ChristophWurst ChristophWurst added the 2. developing Work in progress label Dec 6, 2023
@ChristophWurst ChristophWurst self-assigned this Dec 6, 2023
@ChristophWurst ChristophWurst mentioned this pull request Dec 6, 2023
Closed
@susnux susnux added this to the Nextcloud 30 milestone Apr 18, 2024
@skjnldsv skjnldsv removed this from the Nextcloud 30 milestone Aug 14, 2024
@ChristophWurst ChristophWurst marked this pull request as ready for review September 17, 2024 21:58
@ChristophWurst ChristophWurst added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Sep 17, 2024
@tcitworld
Copy link
Member

tcitworld commented Sep 18, 2024

Needs a rebase

@ChristophWurst ChristophWurst force-pushed the fix/carddav/create-sab-concurrently branch from a076356 to 9ba2828 Compare September 18, 2024 07:57
ChristophWurst
ChristophWurst commented Sep 18, 2024
View reviewed changes
@ChristophWurst ChristophWurst force-pushed the fix/carddav/create-sab-concurrently branch from 9ba2828 to 0e1d12b Compare September 18, 2024 08:08
@skjnldsv skjnldsv enabled auto-merge November 6, 2024 08:02
@ChristophWurst @skjnldsv
fix(carddav): Handle race for SAB creation better
0bb68ab 
* Accept non repeatable read and INSERT conflict by another read
* Handle replication edge case

Signed-off-by: Christoph Wurst <[email protected]>
@skjnldsv skjnldsv force-pushed the fix/carddav/create-sab-concurrently branch from 0e1d12b to 0bb68ab Compare November 6, 2024 08:13
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Nov 6, 2024
@skjnldsv skjnldsv merged commit 373ad6c into master Nov 6, 2024
178 checks passed
@skjnldsv skjnldsv deleted the fix/carddav/create-sab-concurrently branch November 6, 2024 08:29
@skjnldsv skjnldsv mentioned this pull request Jan 7, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@miaulalala miaulalala miaulalala approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@tcitworld tcitworld Awaiting requested review from tcitworld

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

@st3iny st3iny Awaiting requested review from st3iny

@SebastianKrupinski SebastianKrupinski Awaiting requested review from SebastianKrupinski SebastianKrupinski is a code owner

Assignees

@ChristophWurst ChristophWurst

Labels

4. to release Ready to be released and/or waiting for tests to finish

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

System address book creation errors on concurrent user creation

6 participants

@ChristophWurst @tcitworld @miaulalala @skjnldsv @susnux