Skip to content

perf: improve performance of resolving group shares #44004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
skjnldsv merged 1 commit into from
Mar 16, 2024
Merged

perf: improve performance of resolving group shares #44004

skjnldsv merged 1 commit into from
Mar 16, 2024

Conversation

@icewind1991
Copy link
Member

@icewind1991 icewind1991 commented Mar 5, 2024 •
edited
Loading

Noticed that the resolving of shares is creating a fairly significant load on the DB. Instead of sending a massive IN statement, filtering just by the recipient is enough and should be a lot better on the DB.

@icewind1991 icewind1991 added this to the Nextcloud 29 milestone Mar 5, 2024
@icewind1991 icewind1991 marked this pull request as ready for review March 5, 2024 16:11
@icewind1991 icewind1991 added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Mar 5, 2024
@icewind1991 icewind1991 requested review from a team, ArtificialOwl, nfebe and sorbaugh and removed request for a team March 5, 2024 16:11
@icewind1991 icewind1991 mentioned this pull request Mar 5, 2024
Merged
github-advanced-security[bot]
github-advanced-security bot found potential problems Mar 5, 2024
View reviewed changes
@icewind1991 icewind1991 force-pushed the share-resolve-group-perf branch from d28c1f7 to 1ce427d Compare March 6, 2024 09:50
blizzz
blizzz reviewed Mar 7, 2024
View reviewed changes
Altahrim
Altahrim reviewed Mar 8, 2024
View reviewed changes
@skjnldsv skjnldsv requested review from Altahrim and blizzz March 9, 2024 08:22
This was referenced Mar 12, 2024
Merged
Merged
@Altahrim Altahrim force-pushed the share-resolve-group-perf branch 2 times, most recently from ef4f968 to 45f0de2 Compare March 15, 2024 15:30
@Altahrim Altahrim requested a review from skjnldsv March 15, 2024 15:30
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Mar 15, 2024
@skjnldsv skjnldsv force-pushed the share-resolve-group-perf branch from 45f0de2 to 0e74972 Compare March 16, 2024 12:20
@skjnldsv skjnldsv merged commit 1ecf3b3 into master Mar 16, 2024
@skjnldsv skjnldsv deleted the share-resolve-group-perf branch March 16, 2024 13:05
@Altahrim Altahrim mentioned this pull request Mar 18, 2024
Merged
@skjnldsv skjnldsv mentioned this pull request Mar 19, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Altahrim Altahrim Altahrim approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl ArtificialOwl is a code owner automatically assigned from nextcloud/server-backend

@nfebe nfebe Awaiting requested review from nfebe nfebe is a code owner automatically assigned from nextcloud/server-backend

@sorbaugh sorbaugh Awaiting requested review from sorbaugh sorbaugh is a code owner automatically assigned from nextcloud/server-backend

@blizzz blizzz Awaiting requested review from blizzz

Assignees

No one assigned

Labels

4. to release Ready to be released and/or waiting for tests to finish performance 🚀

Projects

None yet

Milestone

Nextcloud 29

Development

Successfully merging this pull request may close these issues.

5 participants

@icewind1991 @blizzz @Altahrim @skjnldsv