feat: Adding PublicSectorBundle #44011
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndyScherzinger
approved these changes
Mar 6, 2024
Member
AndyScherzinger
left a comment
AndyScherzinger
left a comment
There was a problem hiding this comment.
Lgtm, how about also adding the audit app?
Member
loosely connected, but would be a reason to consider making https://docs.nextcloud.com/server/latest/admin_manual/configuration_server/logging_configuration.html#log-level-interaction the default, or even enforced. It's a bit counter intuitive in general to switch this one through the log condition, and having audit_log enabled should be already sufficient for logging. |
Member
|
@sorbaugh can you align on #44011 (comment) Other than that I think the PR is good to go for the moment 👍 |
Member
|
Can ship with beta2 as is, so marketing can do their screenshots |
Member
|
Fine to merge for Rc2 then 👍 |
AndyScherzinger
added
the
4. to release
Merged
Signed-off-by: Christopher Ng <[email protected]>
Pytal
force-pushed
the
sorbaugh/public-bundle
branch
from
d3c8e51 to
82a1724
Compare
Signed-off-by: Christopher Ng <[email protected]>
Pytal
force-pushed
the
sorbaugh/public-bundle
branch
from
3770c9c to
af49278
Compare
Member
|
Force merged in alignment with @sorbaugh |
Contributor
Author
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a new Bundle for public sectorr
TODO
Checklist