Skip to content

Conversation

@artonge
Copy link
Contributor

@artonge artonge commented Mar 7, 2024

Fix #43299

Done

  • Split live photo listener to extract trash specific code into its folder
  • Write e2e code to ensure nothing broke
  • Disable ajax cron to make e2e tests faster and more reliable
  • Update scroll strategy in e2e tests to ensure files row are not hided under the static top bar

TODO

  • Backport to stable28

@artonge artonge self-assigned this Mar 7, 2024
@artonge artonge added the 2. developing Work in progress label Mar 7, 2024
@artonge artonge added this to the Nextcloud 29 milestone Mar 7, 2024
@artonge artonge force-pushed the artonge/fix/split_live_photo_listener branch from c9f3267 to 3640bd7 Compare March 8, 2024 11:24
@artonge artonge force-pushed the artonge/fix/split_live_photo_listener branch 2 times, most recently from 4146c2a to 68ebdfb Compare March 11, 2024 14:08
@artonge artonge force-pushed the artonge/fix/split_live_photo_listener branch from 68ebdfb to 398727b Compare March 11, 2024 17:09
@Altahrim Altahrim mentioned this pull request Mar 12, 2024
@artonge artonge force-pushed the artonge/fix/split_live_photo_listener branch 3 times, most recently from 2852e39 to db6269c Compare March 12, 2024 11:34
@artonge artonge marked this pull request as ready for review March 12, 2024 12:32
@artonge artonge requested a review from skjnldsv as a code owner March 12, 2024 12:32
@artonge artonge force-pushed the artonge/fix/split_live_photo_listener branch 3 times, most recently from 66fdc90 to 53fb9d4 Compare March 12, 2024 13:14
@artonge artonge removed the request for review from skjnldsv March 12, 2024 13:21
@artonge artonge added php Pull requests that update Php code tests Related to tests labels Mar 12, 2024
@artonge artonge force-pushed the artonge/fix/split_live_photo_listener branch 4 times, most recently from 0710141 to eee43f9 Compare March 12, 2024 17:52
@artonge artonge added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Mar 12, 2024
@artonge artonge changed the title Split live photos listener Split live photo listener to extract trashbin specific code into its own listener Mar 12, 2024
@artonge artonge force-pushed the artonge/fix/split_live_photo_listener branch 3 times, most recently from ce472e6 to 3da98b0 Compare March 13, 2024 10:09
@susnux susnux requested review from a team and icewind1991 and removed request for a team March 13, 2024 11:53
@Altahrim Altahrim mentioned this pull request Mar 14, 2024
Copy link
Contributor

@come-nc come-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@artonge artonge force-pushed the artonge/fix/split_live_photo_listener branch from 3da98b0 to 491a5e9 Compare March 14, 2024 09:55
artonge added 4 commits March 14, 2024 10:55
This prevent random slowdown during tests, making them more reliable, and faster.

Signed-off-by: Louis Chemineau <[email protected]>
This avoid elements to be hided by a fixed top bar.
Especially useful for the file list.

Signed-off-by: Louis Chemineau <[email protected]>
@artonge artonge force-pushed the artonge/fix/split_live_photo_listener branch from 491a5e9 to 01fe326 Compare March 14, 2024 10:07
@artonge artonge merged commit dd26fb2 into master Mar 14, 2024
@artonge artonge deleted the artonge/fix/split_live_photo_listener branch March 14, 2024 11:50
@joshtrichards
Copy link
Member

/backport to stable28

@joshtrichards
Copy link
Member

TODO:

  • Backport to stable28

Looks like the backport got missed :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews bug feature: files php Pull requests that update Php code tests Related to tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: \OCA\Files\Listener\SyncLivePhotosListener requires files_trashbin to be enabled

6 participants