fix(files): Right click menu offset and list scrolled glitch #44139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
/backport to stable28 |
This comment was marked as resolved.
This comment was marked as resolved.
skjnldsv
approved these changes
Mar 12, 2024
Merged
Signed-off-by: Christopher Ng <[email protected]>
Pytal
force-pushed
the
fix/right-click-files-list
branch
from
4c5a5aa to
3c4048d
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Contributor
|
Much better now! Only thing I noticed is an offset issue when the menu opens to the top: Bildschirmaufnahme.2024-03-12.um.22.03.05.mov |
Signed-off-by: Christopher Ng <[email protected]>
Signed-off-by: Christopher Ng <[email protected]>
Signed-off-by: Christopher Ng <[email protected]>
Pytal
force-pushed
the
fix/right-click-files-list
branch
from
3c4048d to
84ceadd
Compare
SystemKeeper
approved these changes
Mar 13, 2024
Contributor
SystemKeeper
left a comment
SystemKeeper
left a comment
There was a problem hiding this comment.
As discussed, works fine in the tested scenarios. A small mis-alignment can still happen if the menu is rerendered with less items than before, but nothing to adjust for this PR.
3 tasks
Merged
Closed
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Checklist