fix(s3): Don't wait indefinitely for S3 to return #46317
Conversation
|
/backport to stable29 |
|
/backport to stable28 |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
solracsf
force-pushed
the
s3InsertTimeout
branch
4 times, most recently
from
b284748 to
1ce2838
Compare
Signed-off-by: Git'Fellow <[email protected]> fix: lint Signed-off-by: Git'Fellow <[email protected]> fix: use AwsException Signed-off-by: Git'Fellow <[email protected]> fix: Throw on connection failure Signed-off-by: Git'Fellow <[email protected]> fix: Wrap all in try catch block Signed-off-by: Git'Fellow <[email protected]> fix: use RequestTimeout error message Signed-off-by: Git'Fellow <[email protected]> log: use OCP Server class Signed-off-by: Git'Fellow <[email protected]> fix: Handle connect timeout only Signed-off-by: Git'Fellow <[email protected]> fix: Handle errors more generically Signed-off-by: Git'Fellow <[email protected]>
|
/backport to stable29 |
|
/backport to stable28 |
solracsf
added
feature: object storage
4. to release
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
Summary
By default, SDK never timeout. Insert some sane defaults.
https://docs.aws.amazon.com/sdk-for-php/v3/developer-guide/guide_configuration.html#config-http
Checklist