feat(settings): Add setup check for apcu cache expunge #47507
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
juliusknorr
force-pushed
the
feat/apcu-setup-check
branch
from
e3cd7dc to
94da937
Compare
juliusknorr
added
enhancement
3. to review
Signed-off-by: Julius Härtl <[email protected]>
juliusknorr
force-pushed
the
feat/apcu-setup-check
branch
from
3347249 to
f3419c5
Compare
juliusknorr
requested review from
a team,
artonge,
come-nc,
nickvergessen and
skjnldsv
and removed request for
a team
skjnldsv
approved these changes
Aug 27, 2024
Member
|
Nice! |
nickvergessen
approved these changes
Aug 27, 2024
come-nc
reviewed
Aug 29, 2024
Contributor
come-nc
left a comment
come-nc
left a comment
There was a problem hiding this comment.
Does that apply to cli as well? Remember that setupchecks can be run by occ and in this case they use the php cli ini file which is not configured the same as web.
Member
Author
|
Right, we cannot really check in cli as there is no shared memory with what ever SAPI is used. |
Contributor
Then the check should check the CLI flag and bail out, take inspiration from other php config related checks. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This adds a basic setup check to warn admins if their APCu cache is close to be full or has been expunged. Ideally we would be able to calculate something like a rate for how long the cache is kept until cleaned up, but i couldn't find a reasonable metric and we cannot get the startup time of the php service itself.
Checklist