-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Fix/move image to oc namespace #47535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
17dec99 to
0010f28
Compare
Signed-off-by: Côme Chilliet <[email protected]>
Signed-off-by: Côme Chilliet <[email protected]>
Signed-off-by: Côme Chilliet <[email protected]>
Signed-off-by: Côme Chilliet <[email protected]>
Signed-off-by: Côme Chilliet <[email protected]>
Signed-off-by: Côme Chilliet <[email protected]>
f296d19 to
1f46be7
Compare
|
This broke Talk nextcloud/spreed#13197 and using the OCP replacement does not work. To fix this \OCP\Image needs to implement \OCP\IImage directly and the missing method need to be added to \OCP\IImage. |
Summary
Move legacy
OC_Imageinto\OC\Imageand update code style and remove deprecated references in there.This class is exposed through
OCP\Imagewhich is used by applications withnew \OCP\Image()and then\OCP\IImagemethods can be used on it.This still leaves a reference to
OCfromOCPwhich we try to avoid.But this would mean adding an
IImageFactorywhich applications needs to DI, not sure this is worth it.Checklist