refactor: Migrate public-page header actions to Vue #47568
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susnux
added
enhancement
3. to review
susnux
force-pushed
the
refactor/migrate-public-page-menu-vue
branch
2 times, most recently
from
4dbffa0 to
1fc41ee
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This was referenced Aug 29, 2024
skjnldsv
approved these changes
Aug 30, 2024
susnux
force-pushed
the
refactor/migrate-public-page-menu-vue
branch
from
1fc41ee to
0a49d60
Compare
Contributor
Author
|
@jancborchardt all of the remarks are fixed, I updated the screen recording in the initial post to reflect the current state. |
artonge
approved these changes
Sep 2, 2024
core/src/components/PublicPageMenu/PublicPageMenuExternalDialog.vue
Outdated
Show resolved
Hide resolved
susnux
force-pushed
the
refactor/migrate-public-page-menu-vue
branch
2 times, most recently
from
4a13c16 to
1312505
Compare
skjnldsv
added
4. to release
susnux
force-pushed
the
refactor/migrate-public-page-menu-vue
branch
from
1312505 to
bf85548
Compare
This adds a Vue implementation of the public page menu, that is the menu that can be added using `PublicTemplateResponse::setHeaderActions`. Co-authored-by: Ferdinand Thiessen <[email protected]> Co-authored-by: Louis <[email protected]> Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
This removes custom rendering code an replaces it with the declarative menu actions. Also adjust the template to allow the Vue UI to mount. Custom entries still are possible. Signed-off-by: Ferdinand Thiessen <[email protected]>
Keep them in the constructor to not break the API, but they are not used anymore. This way of adding a share was deprecated in Nextcloud 12 (2016!), in favor of the federated share API, in Nextcloud 28 this way to create a share was removed. So we can cleanup as all it takes now to create a federeated share is the share token + federated user ID. Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
susnux
force-pushed
the
refactor/migrate-public-page-menu-vue
branch
from
bf85548 to
0f76409
Compare
Signed-off-by: Ferdinand Thiessen <[email protected]> Signed-off-by: nextcloud-command <[email protected]>
nextcloud-command
force-pushed
the
refactor/migrate-public-page-menu-vue
branch
from
0f76409 to
5610821
Compare
4 tasks
4 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The header menu was still using legacy jQuery UI and duplicated styles in many places instead of reusing the header menu styles we use for the logged-in apps view.
So this PR is migrating that menu to Vue:
getDatamethod that allows to just return the data needed for rendering)renderfunction for custom entries app developers might have implemented (so this PR is non breaking).Screen recording
Bildschirmaufnahme_20240830_162107.webm
Details
First version:Bildschirmaufnahme_20240828_143026.webm
Checklist