Skip to content

chore(db): Make the query more simple to read #47675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
skjnldsv merged 3 commits into from
Sep 4, 2024
Merged

chore(db): Make the query more simple to read #47675

skjnldsv merged 3 commits into from
Sep 4, 2024

Conversation

@solracsf
Copy link
Member

@solracsf solracsf commented Sep 2, 2024

Checklist

@solracsf solracsf added this to the Nextcloud 31 milestone Sep 2, 2024
@solracsf
fix: psalm
388f297 
Signed-off-by: Git'Fellow <[email protected]>
@solracsf solracsf added the 2. developing Work in progress label Sep 2, 2024
@solracsf
fix: psalm
8e6e797 
Signed-off-by: Git'Fellow <[email protected]>
@solracsf solracsf changed the title chore(db): Make the query more simpler to read chore(db): Make the query more simple to read Sep 2, 2024
@solracsf solracsf added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Sep 2, 2024
susnux
susnux reviewed Sep 2, 2024
View reviewed changes
@susnux susnux added ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring) feature: database Database related DB labels Sep 2, 2024
@susnux susnux requested review from a team, ArtificialOwl, come-nc and sorbaugh and removed request for a team September 2, 2024 15:47
@come-nc come-nc requested a review from Altahrim September 3, 2024 07:50
Altahrim
Altahrim approved these changes Sep 3, 2024
View reviewed changes
Copy link
Collaborator

@Altahrim Altahrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer to get rid of insertIfNotExist since it's deprecated since Nextcloud 15 :p
This function is unsafe since column names are not escaped

@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Sep 4, 2024
@skjnldsv skjnldsv merged commit 7efd244 into master Sep 4, 2024
@skjnldsv skjnldsv deleted the adapterQueryOpti branch September 4, 2024 07:15
@skjnldsv skjnldsv mentioned this pull request Jan 7, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@susnux susnux susnux left review comments

@Altahrim Altahrim Altahrim approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl ArtificialOwl is a code owner automatically assigned from nextcloud/server-backend

@sorbaugh sorbaugh Awaiting requested review from sorbaugh sorbaugh is a code owner automatically assigned from nextcloud/server-backend

@come-nc come-nc Awaiting requested review from come-nc come-nc is a code owner automatically assigned from nextcloud/server-backend

Assignees

No one assigned

Labels

4. to release Ready to be released and/or waiting for tests to finish feature: database Database related DB ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring)

Projects

None yet

Milestone

Nextcloud 31

Development

Successfully merging this pull request may close these issues.

5 participants

@solracsf @susnux @Altahrim @skjnldsv