chore(files): Use public API where possible #47792
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is not fixing all issues in the helper, but at least where possible use the public methods. Signed-off-by: Ferdinand Thiessen <[email protected]>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| if (isset($i['is_share_mount_point'])) { | ||
| $entry['isShareMountPoint'] = $i['is_share_mount_point']; | ||
| } | ||
| if (isset($i['extraData'])) { |
Check notice
Code scanning / Psalm
UndefinedInterfaceMethod
provokateurin
approved these changes
Sep 6, 2024
Member
|
I think you could cast it to the internal type (for safety) and then access the getters from there? It would at least ensure you never call the getters on some other class. |
come-nc
approved these changes
Sep 9, 2024
Contributor
come-nc
left a comment
come-nc
left a comment
There was a problem hiding this comment.
Yeah maybe wrap in an if (instanceof) the arrayaccess part, maybe with an else clause logging an error to be safe.
Or clean it up and add getters for this info (or find a way to access it using public API if it exists)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is not fixing all issues in the helper, but at least where possible use the public methods.
For the rest I am not sure what the best solution would be, just ignore? Make the data access public (probably not)...
Checklist