chore(legacy): Introduce public version class and drop version methods from OC_Util #48152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliusknorr
force-pushed
the
clean/version-ocp
branch
from
a511a8e to
1076be8
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
juliusknorr
force-pushed
the
clean/version-ocp
branch
5 times, most recently
from
6c038da to
2e206ca
Compare
juliusknorr
requested review from
a team,
come-nc,
icewind1991,
nickvergessen and
skjnldsv
and removed request for
a team
juliusknorr
force-pushed
the
clean/version-ocp
branch
from
2e206ca to
6273f9a
Compare
come-nc
approved these changes
Sep 18, 2024
nickvergessen
previously requested changes
Sep 19, 2024
juliusknorr
force-pushed
the
clean/version-ocp
branch
from
6273f9a to
ad671b1
Compare
juliusknorr
force-pushed
the
clean/version-ocp
branch
2 times, most recently
from
880cd95 to
31f4e27
Compare
susnux
approved these changes
Sep 19, 2024
…hods from OC_Util Signed-off-by: Julius Knorr <[email protected]>
juliusknorr
force-pushed
the
clean/version-ocp
branch
from
31f4e27 to
606241c
Compare
Member
|
Since this was defacto-standard, please document the new API and mention the removal in the docs |
nickvergessen
added
the
pending documentation
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Next step could be to deprecated related OCP\Util methods.