fix(files_external): Catch correct exception #48345
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
/backport to stable30 |
Member
Author
|
/backport to stable29 |
Member
Author
|
/backport to stable28 |
marcelklehr
force-pushed
the
fix/files_external/forbidden-exception
branch
from
6059c15 to
45d6411
Compare
Contributor
|
Thank you, good finding 👍 Could you please update the phpdoc for getFileInfo and add |
kesselb
approved these changes
Sep 25, 2024
icewind1991
approved these changes
Sep 25, 2024
marcelklehr
force-pushed
the
fix/files_external/forbidden-exception
branch
from
45d6411 to
cd0742c
Compare
SMB#getFileInfo used to throw an icewind/smb exception, but nowadays throws \OCP\Files\ForbiddenException. This fixes downstream methods to catch the new exception. Signed-off-by: Marcel Klehr <[email protected]>
marcelklehr
force-pushed
the
fix/files_external/forbidden-exception
branch
from
cd0742c to
c8a90e9
Compare
This was referenced Sep 26, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SMB#getFileInfo used to throw an icewind/smb exception, but nowadays throws \OCP\Files\ForbiddenException. This fixes downstream methods to catch the new exception.
Checklist