Skip to content

fix(theming): Use AppConfig for setting background image #48439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kesselb merged 1 commit into from
Sep 30, 2024
Merged

fix(theming): Use AppConfig for setting background image #48439

kesselb merged 1 commit into from
Sep 30, 2024

Conversation

@susnux
Copy link
Contributor

@susnux susnux commented Sep 28, 2024 •
edited
Loading

Summary

We need to use the AppConfig consistently otherwise it will hard-fail like it does currently.

Checklist

@susnux susnux requested review from a team, ArtificialOwl, come-nc, kesselb and yemkareems and removed request for a team September 28, 2024 20:48
@susnux susnux added this to the Nextcloud 31 milestone Sep 28, 2024
@susnux
Copy link
Contributor Author

susnux commented Sep 28, 2024

/backport to stable30

kesselb
kesselb approved these changes Sep 30, 2024
View reviewed changes
Copy link
Contributor

@kesselb kesselb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@kesselb kesselb merged commit be87dec into master Sep 30, 2024
@kesselb kesselb deleted the fix/background-image branch September 30, 2024 10:42
@backportbot backportbot bot mentioned this pull request Sep 30, 2024
Merged
@skjnldsv skjnldsv mentioned this pull request Jan 7, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kesselb kesselb kesselb approved these changes

@come-nc come-nc come-nc approved these changes

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl ArtificialOwl is a code owner automatically assigned from nextcloud/server-backend

@yemkareems yemkareems Awaiting requested review from yemkareems yemkareems is a code owner automatically assigned from nextcloud/server-backend

Assignees

No one assigned

Labels

3. to review Waiting for reviews bug feature: theming

Projects

None yet

Milestone

Nextcloud 31

Development

Successfully merging this pull request may close these issues.

[Bug]: Uploading a new Background Image displays error "conflict between new type (mixed) and old type (string)"

4 participants

@susnux @kesselb @come-nc