Skip to content

Conversation

@come-nc
Copy link
Contributor

@come-nc come-nc commented Oct 3, 2024

Summary

Fix issues from #44871 .
We cannot get the id before the write, because the file may not exist yet. On the contrary for delete we need to get it before deletion.
I remove the "update" listener since this hook has no equivalent in the events (and it is not really needed, it’s the same as NodeWrittenEvent, only difference is the update hook was only called for modifications and not for creations).

Checklist

@come-nc come-nc added the bug label Oct 3, 2024
@come-nc come-nc added this to the Nextcloud 31 milestone Oct 3, 2024
@come-nc come-nc requested a review from yemkareems October 3, 2024 09:02
@come-nc come-nc self-assigned this Oct 3, 2024
@come-nc
Copy link
Contributor Author

come-nc commented Oct 3, 2024

/backport to stable30

@come-nc come-nc requested review from a team, Altahrim and icewind1991 and removed request for a team October 3, 2024 09:05
@come-nc come-nc merged commit a9331e1 into master Oct 3, 2024
@come-nc come-nc deleted the fix/fix-admin-audit-event-listening branch October 3, 2024 12:07
@skjnldsv skjnldsv mentioned this pull request Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Error: admin_audit: NotFoundException Exception thrown in file write: Exception thrown in file write:

4 participants