fix(app-store): Update update count in navigation #48871
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
/backport to stable30 |
Contributor
Author
|
/backport to stable29 |
provokateurin
approved these changes
Oct 23, 2024
artonge
approved these changes
Oct 24, 2024
Signed-off-by: Ferdinand Thiessen <[email protected]>
susnux
force-pushed
the
fix/app-store-reactivity
branch
from
5162a10 to
bcaf954
Compare
Contributor
Author
|
/compile |
Signed-off-by: nextcloud-command <[email protected]>
This was referenced Oct 28, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The update count was not reactive anymore since the work on the discover feature.
So this is only bandage, but the proper fix of replacing the vuex store fully with the second pinia store is only possible or 31.
Screen recording
Bildschirmaufnahme_20241023_192659.webm
Checklist