Skip to content

Conversation

@provokateurin
Copy link
Member

@provokateurin provokateurin commented Oct 28, 2024

Summary

Checklist

@provokateurin provokateurin added bug 3. to review Waiting for reviews labels Oct 28, 2024
@provokateurin provokateurin added this to the Nextcloud 31 milestone Oct 28, 2024
@provokateurin provokateurin requested review from a team, artonge, skjnldsv and sorbaugh and removed request for a team October 28, 2024 07:08
@provokateurin
Copy link
Member Author

/backport to stable30

@provokateurin
Copy link
Member Author

/backport to stable29

@provokateurin
Copy link
Member Author

/backport to stable28

Copy link
Contributor

@nfebe nfebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe some of the messages can be more specific? For example the try-catch that fails due to date parsing and only that can be a bit more explicit at maybe the expense of consistency with the same "Failed to..."

@provokateurin provokateurin force-pushed the fix/files_sharing/cleanup-error-messages branch from 64fd4eb to 53ddaa3 Compare October 28, 2024 07:55
@provokateurin
Copy link
Member Author

Maybe some of the messages can be more specific? For example the try-catch that fails due to date parsing and only that can be a bit more explicit at maybe the expense of consistency with the same "Failed to..."

Fixed. The called method was already returning a proper error message, so I aligned all the uses of it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants