fix(richobjectstrings): Add missing placeholder validation #49116
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Some apps were using placeholders with spaces, @ and slashes. But the frontend only allowed
[a-z\-_.0-9]+https://github.com/nextcloud-libraries/nextcloud-vue/blob/master/src/components/NcRichText/NcRichText.vue#L396-L397
At the same time, using
0-9only would break in PHP as that makes it not a string anymore but a number, so additionally we now require the placeholder to start witha-zA-ZThe recommended workaround is to not use "user ids" and other things directly, but instead using hardcoded strings like
actoror "counting keys" likeuser-1, similar to how comments does it on it's activities:server/apps/comments/lib/Activity/Provider.php
Line 110 in 096f893
server/apps/comments/lib/Activity/Provider.php
Line 162 in 096f893
Checklist