fix(systemtags): enhance create tag in tag picker UX #49129
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skjnldsv
requested review from
Pytal,
susnux and
szaimen
and removed request for
a team
marcoambrosini
approved these changes
Nov 8, 2024
Member
marcoambrosini
left a comment
marcoambrosini
left a comment
There was a problem hiding this comment.
Very nice, what do you think about making it full width?
Member
Author
In my todo, when i'll schedule a full review with the design team :) |
Member
Author
|
Will fix cypress test |
Signed-off-by: skjnldsv <[email protected]>
skjnldsv
force-pushed
the
feat/systemtags-bulk-create-list
branch
from
51a2dff to
99a7346
Compare
Signed-off-by: skjnldsv <[email protected]>
susnux
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #49026
Better with nextcloud-libraries/nextcloud-vue#6197 (but not a blocker)